Repository navigation
test(cpp): read concore.params from in1/ in the tryparam list test - #676
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the "tryparam preserves list with comma" test in
TestConcoreHpp.cppwritesin/1/concore.params, butConcore::load_params()reads<inpath>1/concore.params, i.e.in1/concore.params(the other tests in the file also usein1/). The test therefore never finds its file, and two checks (tryparam preserves list with comma,tryparam preserves subsequent key) fail, which turns the C++ CI jobs red.Change: write and remove the params file at
in1/concore.params. No library code changes.Testing:
g++ -std=c++11 -Wall -Wextra -I. -o TestConcoreHpp TestConcoreHpp.cpp && ./TestConcoreHppgoes from34 passed, 2 failedto36 passed, 0 failed(checked on macOS and Linux).